Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Codeserver ImageStream for the 2024a release inclusion #173

Merged

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Mar 12, 2024

Related to: https://issues.redhat.com/browse/RHOAIENG-4345

This PR updates code-server's ImageStream object to include the new 2024a release.

NOTE: The updates to the code-server notebook itself will be included with the sync with upstream.
Changes are introduced here: opendatahub-io#452

@openshift-ci openshift-ci bot requested review from dibryant and harshad16 March 12, 2024 16:18
Copy link

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from atheo89. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89 atheo89 changed the title Update Codeserver ImageStream with the 2024a release inclusion Update Codeserver ImageStream for the 2024a release inclusion Mar 12, 2024
@atheo89 atheo89 force-pushed the RHOAIENG-4345-downstream branch from 237736c to 34620cc Compare March 12, 2024 16:21
@atheo89 atheo89 force-pushed the RHOAIENG-4345-downstream branch from 34620cc to 2ed767f Compare March 15, 2024 07:46
Copy link

openshift-ci bot commented Mar 15, 2024

@atheo89: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 2ed767f link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm , just few comments.

manifests/base/code-server-notebook-imagestream.yaml Outdated Show resolved Hide resolved
manifests/base/code-server-notebook-imagestream.yaml Outdated Show resolved Hide resolved
@harshad16 harshad16 merged commit 1ea1d49 into red-hat-data-services:main Mar 17, 2024
3 of 6 checks passed
@atheo89 atheo89 deleted the RHOAIENG-4345-downstream branch October 23, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants