-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QLoRA sanity test for training operator #1852
Merged
sutaakar
merged 1 commit into
red-hat-data-services:master
from
abhijeet-dhumal:add-qlora-sanity-test
Sep 24, 2024
Merged
Add QLoRA sanity test for training operator #1852
sutaakar
merged 1 commit into
red-hat-data-services:master
from
abhijeet-dhumal:add-qlora-sanity-test
Sep 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijeet-dhumal
requested review from
sutaakar,
jiripetrlik and
ChughShilpa
September 24, 2024 08:38
Quality Gate passedIssues Measures |
@@ -10,7 +10,7 @@ | |||
${CODEFLARE-SDK_DIR} codeflare-sdk | |||
${CODEFLARE-SDK_REPO_URL} %{CODEFLARE-SDK_REPO_URL=https://github.com/project-codeflare/codeflare-sdk.git} | |||
${DISTRIBUTED_WORKLOADS_RELEASE_ASSETS} https://github.com/opendatahub-io/distributed-workloads/releases/latest/download | |||
${FMS_HF_TUNING_IMAGE} quay.io/modh/fms-hf-tuning@sha256:8edea6f0f9c4c631cdca1e1c10abf0d4b994738fde78c40d48eda216fdd382f5 | |||
${FMS_HF_TUNING_IMAGE} quay.io/modh/fms-hf-tuning@sha256:f8f732c340488734bf9023953d14bb2410991bd3ff2a519ad2ce07c531353797 |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
Line is too long (139/120)
Robot Results
|
sutaakar
reviewed
Sep 24, 2024
ods_ci/tests/Tests/0600__distributed_workloads/0602__training/test-run-tuning-stack-tests.robot
Show resolved
Hide resolved
abhijeet-dhumal
force-pushed
the
add-qlora-sanity-test
branch
from
September 24, 2024 10:40
d27b025
to
0eb5075
Compare
ChughShilpa
reviewed
Sep 24, 2024
ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource
Show resolved
Hide resolved
ChughShilpa
approved these changes
Sep 24, 2024
sutaakar
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RHOAIENG-13142
Related PR : opendatahub-io/distributed-workloads#232
Tested manually :