Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] expected version in the 2024.2 images #1919

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

jstourac
Copy link
Member

@jstourac jstourac commented Oct 10, 2024

Apart from the title, also extra exception for a newly introduced cuda bundle in tensorflow image and the test is extended also for the TrustyAI image.

Notebook python package is no longer dependency required by Jupyterlab package, so it is missing from the images now.


CI:
image

Note: the failures are expected due to the bug in the release, fix is on the way opendatahub-io/notebooks#742

@jstourac jstourac added the enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) label Oct 10, 2024
@jstourac jstourac self-assigned this Oct 10, 2024
${JupyterLab_Version} v3.6
${Notebook_Version} v6.5
${JupyterLab-git_Version} v0.44
${JupyterLab_Version} v4.2

Check warning

Code scanning / Robocop

Section variable '{{ variable_name }}' name should be uppercase Warning test

Section variable '${JupyterLab_Version}' name should be uppercase
${Notebook_Version} v6.5
${JupyterLab-git_Version} v0.44
${JupyterLab_Version} v4.2
${JupyterLab-git_Version} v0.50

Check warning

Code scanning / Robocop

Section variable '{{ variable_name }}' name should be uppercase Warning test

Section variable '${JupyterLab-git_Version}' name should be uppercase
Copy link
Contributor

github-actions bot commented Oct 10, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
545 0 0 545 100

@jstourac jstourac force-pushed the fixImagePkgVersions branch from 8b2b1a7 to f96b908 Compare October 11, 2024 10:34
@jstourac jstourac marked this pull request as ready for review October 11, 2024 11:21
@jstourac jstourac added the verified This PR has been tested with Jenkins label Oct 11, 2024
@jstourac jstourac requested review from lugi0, jgarciao and jiridanek and removed request for lugi0 October 11, 2024 11:22
Apart from the title, also extra exception for a newly introduced cuda
bundle in tensorflow image.

Notebook python package is no longer dependency required by Jupyterlab
package, so it is missing from the images now.
@jstourac jstourac force-pushed the fixImagePkgVersions branch from 4c131cb to aadec47 Compare October 11, 2024 11:25
Copy link

@jstourac jstourac merged commit f0b8600 into red-hat-data-services:master Oct 11, 2024
8 checks passed
@jstourac jstourac deleted the fixImagePkgVersions branch October 11, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants