Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile.konflux to use Go 1.22 builder #1027

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

grdryn
Copy link

@grdryn grdryn commented Nov 28, 2024

Description

The UBI8 go-toolset is a single-stream image repository, and therefore won't receive any further updates to the 1.22 tag now that 1.22 is out.

Jira: https://issues.redhat.com/browse/RHOAIENG-16819

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@grdryn grdryn requested a review from MohammadiIram November 28, 2024 19:17
@grdryn
Copy link
Author

grdryn commented Dec 20, 2024

@VaishnaviHire @MohammadiIram I'm not sure which team is responsible for keeping this up-to-date?

@zdtsw
Copy link

zdtsw commented Jan 2, 2025

we can close this PR, once rhoai in ODH is synced here, it should auto update image SHA

@grdryn grdryn requested a review from zdtsw January 2, 2025 15:20
@grdryn
Copy link
Author

grdryn commented Jan 2, 2025

we can close this PR, once rhoai in ODH is synced here, it should auto update image SHA

@zdtsw really? There's no Dockerfile.konflux in the rhoai branch in ODH though, right? How does that get updated as part of the automated sync?

@zdtsw
Copy link

zdtsw commented Jan 2, 2025

we can close this PR, once rhoai in ODH is synced here, it should auto update image SHA

@zdtsw really? There's no Dockerfile.konflux in the rhoai branch in ODH though, right? How does that get updated as part of the automated sync?

you are right.
we do not have Dockerfile.konflux in ODH, thought we wanted to have it in ODH then we can have konflux for ODH nightly as well, but it is not there yet.
in this case, we will need to manually change RHDS to get it in.

@zdtsw
Copy link

zdtsw commented Jan 2, 2025

for tracking: this points to 1.22.9-1 tag

@grdryn grdryn merged commit 033ac20 into red-hat-data-services:main Jan 3, 2025
6 checks passed
@grdryn grdryn deleted the rhoai-go1.22 branch January 3, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants