Addressing review comments

Signed-off-by: Joy John Pinto <86055382+pintojoy@users.noreply.github.com>
red-hat-storage · Oct 10, 2024 · cd27619 · cd27619
1 parent 64ec736
commit cd27619
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/ocs_ci/helpers/helpers.py b/ocs_ci/helpers/helpers.py
@@ -5376,7 +5376,7 @@ def verify_performance_profile_change(perf_profile):
  perf_profile (str): Applied performance profile
 
  Returns:
- True: In case performance profile is updated fails otherwise
+ bool: True in case performance profile is updated, False otherwise
  """
  from ocs_ci.ocs.resources.storage_cluster import StorageCluster
 

diff --git a/tests/functional/z_cluster/test_performance_profile_validation.py b/tests/functional/z_cluster/test_performance_profile_validation.py
@@ -65,9 +65,12 @@ def test_validate_cluster_resource_profile(self, perf_profile):
  try:
  exist_performance_profile = storage_cluster.data["spec"]["resourceProfile"]
  curr_prof = storage_cluster.data["spec"]["resourceProfile"]
- log.info(f"Current performance prfile is {curr_prof}")
+ log.info(f"Current performance profile is {curr_prof}")
  except KeyError:
  # On some occasions, a cluster will be deployed without performance profile, In that case, set it to None.
+ log.info(
+ "If a cluster is deployed without performance profile, set existing_profile value as None"
+ )
  exist_performance_profile = None
  pass
  if exist_performance_profile == self.perf_profile:
@@ -79,7 +82,7 @@ def test_validate_cluster_resource_profile(self, perf_profile):
  f"-n {namespace} --type merge --patch '{ptch}'"
  )
  run_cmd(ptch_cmd)
- log.info("Verify storage cluster is on Ready state")
+ log.info("Verify storage cluster is in Ready state")
  verify_storage_cluster()
 
  # Wait up to 600 seconds for performance changes to reflect
@@ -181,6 +184,9 @@ def test_change_cluster_resource_profile(self, perf_profile):
  exist_performance_profile = storage_cluster.data["spec"]["resourceProfile"]
  except KeyError:
  # On some occasions, a cluster will be deployed without performance profile, In that case, set it to None.
+ log.info(
+ "If a cluster is deployed without performance profile, set existing_profile value as None"
+ )
  exist_performance_profile = None
  pass
  if exist_performance_profile == self.perf_profile: