CNV workload with Discovered Apps #10616
Open
+568
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: prsurve The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
rdr marker needs to be added
Signed-off-by: prsurve <prsurve@redhat.com>
Signed-off-by: prsurve <prsurve@redhat.com>
Signed-off-by: prsurve <prsurve@redhat.com>
Signed-off-by: prsurve <prsurve@redhat.com>
prsurve
force-pushed
the
discovered_app_cnv
branch
from
e6c5435
to
0963bb9
Compare
| skip_replication_resources=skip_replication_resources, | ||
| ) | ||
|
|
||
| def delete_workload(self, force=False): |
There was a problem hiding this comment.
force parameter is not being used anywhere. Needs to be removed
ebenahar
reviewed
Oct 14, 2024
|
|
||
| class CnvWorkloadDiscoveredApps(DRWorkload): | ||
| """ | ||
| Class handling everything related to CNV workloads covers Discovered Apps`1 |
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| @rdr |
|
|
||
|
|
||
| @rdr | ||
| @acceptance |
There was a problem hiding this comment.
A few questions about acceptance marker usage here:
- Is this in the context of including RDR in the build acceptance pipeline?
- Do we consider this scenario the basic functionality of RDR? or basic RDR+CNV?
- The criteria of the acceptance suite are tests that if fail we do not accept the build. Isi it the case here?
- Is the test stable enough to degree that we are sure it's a product bug every time it fails?
am-agrawa
reviewed
Oct 14, 2024
| def deploy_workload(self): | ||
| """ | ||
| Deployment specific to busybox workload for Discovered/Imperative Apps |
|
|
||
| def create_namespace(self): | ||
| """ | ||
| Create Namespace for Workload's to run |
There was a problem hiding this comment.
Suggested change
| Create Namespace for Workload's to run | |
| Create namespace for workloads to run |
| def factory(pvc_vm=1): | ||
| """ | ||
| Args: | ||
| kubeobject (int): Number if Discovered Apps workload with kube object protection to be created |
There was a problem hiding this comment.
Suggested change
| kubeobject (int): Number if Discovered Apps workload with kube object protection to be created | |
| kubeobject (int): Number of Discovered Apps workload with kube object protection to be created |
| kubeobject (int): Number if Discovered Apps workload with kube object protection to be created | ||
| Raises: | ||
| ResourceNotDeleted: In case workload resources not deleted properly |
There was a problem hiding this comment.
Suggested change
| ResourceNotDeleted: In case workload resources not deleted properly | |
| ResourceNotDeletedException: In case workload resources are not deleted |
| """ | ||
| Tests to verify cnv application failover and Relocate with Discovered Apps | ||
| There are two test cases: | ||
| 1) Failover to secondary cluster when primary cluster is UP |
There was a problem hiding this comment.
With failover, we should test node down scenario for happy path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.