Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Test cases changed to use custom storageclass names [tier1, tier2] #8439

Closed
wants to merge 35 commits into from
Closed

[WIP] Test cases changed to use custom storageclass names [tier1, tier2] #8439

wants to merge 35 commits into from

Conversation

paraggit
Copy link
Contributor

@paraggit paraggit commented Sep 9, 2023

[WIP] Test cases changed to use custom storageclass names

@paraggit
Test cases changes for the custom storageclass feature
46b35d2 
Signed-off-by: Parag Kamble <pakamble@redhat.com>
@paraggit paraggit requested review from a team as code owners September 9, 2023 10:12
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Sep 9, 2023
@paraggit
Merge branch 'master' into custom_sc_tc_changes
16ffb4f
@paraggit
Fixed tox error
ac9dd75 
Signed-off-by: Parag Kamble <pakamble@redhat.com>
@paraggit
Fixed tox error in fiojob.py
f08f884 
Signed-off-by: Parag Kamble <pakamble@redhat.com>
ocs-ci
ocs-ci reviewed Sep 9, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration: conf/ocsci/custom_storageclass_names.yaml
PR Test Suite: tier1
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job FAILED (installation failed, tests not executed).

@paraggit
Removed unused fixture 'default_storage_classes' from conftests.py file
ded4d37 
Signed-off-by: Parag Kamble <pakamble@redhat.com>
ocs-ci
ocs-ci reviewed Sep 10, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration: conf/ocsci/custom_storageclass_names.yaml
PR Test Suite: tier1
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job UNSTABLE (some or all tests failed).

@paraggit
Fixed some more tests failure caused due to custome storageclass names
a4bd548 
Signed-off-by: Parag Kamble <pakamble@redhat.com>
@paraggit paraggit requested a review from a team as a code owner September 10, 2023 19:29
ocs-ci
ocs-ci reviewed Sep 11, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration: conf/ocsci/custom_storageclass_names.yaml
PR Test Suite: tier1
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job UNSTABLE (some or all tests failed).

@paraggit
Few more tests fixes to use custom default storageclass names
459ad29 
Signed-off-by: Parag Kamble <pakamble@redhat.com>
ocs-ci
ocs-ci reviewed Sep 14, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration: conf/ocsci/custom_storageclass_names.yaml
PR Test Suite: tier1
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job FAILED (installation failed, tests not executed).

ocs-ci
ocs-ci reviewed Sep 15, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration: conf/ocsci/custom_storageclass_names.yaml
PR Test Suite: tier1
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job UNSTABLE (some or all tests failed).

@paraggit
FIxed issue in 'default_storage_class' function
4ea555b 
Signed-off-by: Parag Kamble <pakamble@redhat.com>
ocs-ci
ocs-ci reviewed Sep 16, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration: conf/ocsci/custom_storageclass_names.yaml
PR Test Suite: tier1
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job FAILED (installation failed, tests not executed).

@paraggit
FIxed UI tests cases
9ba1fd7 
Signed-off-by: Parag Kamble <pakamble@redhat.com>
@paraggit
Fixed some tests for tier1 and tier2 marker
d31e439 
Signed-off-by: Parag Kamble <pakamble@redhat.com>
@pull-request-size pull-request-size bot added size/XL and removed size/L PR that changes 100-499 lines labels Sep 23, 2023
@paraggit paraggit requested a review from a team as a code owner October 24, 2023 18:54
ebenahar
ebenahar previously approved these changes Nov 23, 2023
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Nov 23, 2023
DanielOsypenko
DanielOsypenko reviewed Dec 3, 2023
View reviewed changes
tests/manage/mcg/ui/test_mcg_ui.py
storageclass = "ocs-external-storagecluster-ceph-rgw"
if storageclass == constants.DEFAULT_STORAGECLASS_RGW:
storageclass = get_default_storage_class_name(
constants.OCS_COMPONENTS_MAP["rgw"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be get_default_storage_class_name(constants.OCS_COMPONENTS_MAP["rgw"], external_mode=True)

avd-sagare
avd-sagare previously approved these changes Dec 5, 2023
View reviewed changes
@paraggit paraggit dismissed stale reviews from avd-sagare and ebenahar via 999a7c5 December 6, 2023 10:34
@openshift-ci openshift-ci bot removed the lgtm label Dec 6, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 6, 2023

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: paraggit

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

2 similar comments
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: paraggit

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: paraggit

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the lifecycle/stale No recent activity label Mar 25, 2024
@github-actions GitHub Actions
Copy link

This pull request has been automatically closed due to inactivity. Please re-open if these changes are still required.

@github-actions github-actions bot closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@DanielOsypenko DanielOsypenko DanielOsypenko left review comments

@ebenahar ebenahar ebenahar left review comments

@avd-sagare avd-sagare avd-sagare left review comments

Assignees

@ebenahar ebenahar

@avd-sagare avd-sagare

Labels
lifecycle/stale No recent activity needs-rebase size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@paraggit @openshift-merge-robot @ebenahar @avd-sagare @ocs-ci @DanielOsypenko