Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create store tests adapted to 4.14 #8536

Merged
merged 4 commits into from
Oct 9, 2023
Merged

create store tests adapted to 4.14 #8536

merged 4 commits into from
Oct 9, 2023

Conversation

DanielOsypenko
Copy link
Contributor

@DanielOsypenko DanielOsypenko commented Sep 20, 2023 •
edited
Loading

  • refactoring due to a new UI layout and transitions
  • test test_store_creation_and_deletion previously running only against ODF 4.8 adapted to new UI and works with ODF 4.14
    both NamespaceStore and BackingStore creation

@DanielOsypenko DanielOsypenko added ui_automation Squad/Black Covers UI specific test cases such as ODF Dashboard etc. labels Sep 20, 2023
@DanielOsypenko DanielOsypenko self-assigned this Sep 20, 2023
@DanielOsypenko DanielOsypenko changed the title create store tests addopted to 4.14, create store tests adapted to 4.14, Sep 21, 2023
@DanielOsypenko
Copy link
Contributor Author

test run UI on IBM cloud
http://magna002.ceph.redhat.com/ocsci-jenkins/openshift-clusters/dosypenk-209-i/dosypenk-209-i_20230920T084359/logs/deploy-ocs-cluster-build-1695232080.log

Failures:
Black squad
tests/ui/test_non_admin_user.py::TestOBCUi::test_create_storageclass_rbd - fixed in other PR

test run on vSphere
http://magna002.ceph.redhat.com/ocsci-jenkins/openshift-clusters/dosypenk-209/dosypenk-209_20230920T085646/logs/deploy-ocs-cluster-build-1695235733.log

Failures:
Green squad
tests/ui/test_create_pool_block_pool.py::TestPoolUserInterface::test_create_delete_pool[3-True] - known issue, not stable test
tests/ui/test_create_pool_block_pool.py::TestPoolUserInterface::test_create_delete_pool[3-False]
tests/ui/test_create_pool_block_pool.py::TestPoolUserInterface::test_create_delete_pool[2-True]
tests/ui/test_create_pool_block_pool.py::TestPoolUserInterface::test_create_delete_pool[2-False]
Black squad
tests/ui/test_non_admin_user.py::TestOBCUi::test_create_storageclass_rbd - fixed in other PR

ocs-ci
ocs-ci reviewed Sep 21, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: dosypenk-209
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/ui/test_validation_ui.py::TestUserInterfaceValidation::test_dashboard_validation_ui
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job PASSED.

@DanielOsypenko DanielOsypenko marked this pull request as ready for review September 21, 2023 12:05
@DanielOsypenko DanielOsypenko requested review from a team as code owners September 21, 2023 12:05
ebondare
ebondare reviewed Sep 26, 2023
View reviewed changes
ocs_ci/ocs/ui/page_objects/object_storage.py Outdated
from ocs_ci.ocs.ui.page_objects.namespace_store_tab import NameSpaceStoreTab
def select_project(self, cluster_namespace):
"""
Helper function to select openshift-storage project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, this method could be used to select any project, not just openshift-storage, so the docstring and the logging should reflect that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, thanks

ebondare
ebondare previously approved these changes Sep 26, 2023
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Sep 26, 2023
@DanielOsypenko DanielOsypenko changed the title create store tests adapted to 4.14, create store tests adapted to 4.14 Sep 28, 2023
sagihirshfeld
sagihirshfeld previously approved these changes Oct 2, 2023
View reviewed changes
DanielOsypenko
DanielOsypenko commented Oct 2, 2023
View reviewed changes
tests/manage/mcg/ui/test_mcg_ui.py
@@ -156,6 +183,7 @@ def test_standard_bc_creation_and_deletion(
bc_name, policy, [bs.name for bs in test_stores]
)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as question was raised upon these comments, adding a clarification:

I usually try to avoid #TODO's, but this time I left them as a reminder to make the test work properly.
The problem why I can not implement TODO's now, is the test require complete rework with a new test flow, locators, etc.
Currently it has @skipif_ocs_version("!=4.8"). Making this test work goes beyound boundaries of this PR

@sagihirshfeld

@DanielOsypenko DanielOsypenko added the Verified Mark when PR was verified and log provided label Oct 2, 2023
@DanielOsypenko DanielOsypenko requested a review from a team October 2, 2023 15:49
@DanielOsypenko
create store tests addopted to 4.14, refactoring due to new UI layout…
8f526b5 
… and transitions

Signed-off-by: Daniel Osypenko <dosypenk@redhat.com>
@DanielOsypenko
fix docstring
f0d7280 
Signed-off-by: Daniel Osypenko <dosypenk@redhat.com>
@DanielOsypenko
fix logging
029f814 
Signed-off-by: Daniel Osypenko <dosypenk@redhat.com>
@DanielOsypenko DanielOsypenko force-pushed the create_store_tests_added_and_more branch from 53e8c32 to 029f814 Compare October 5, 2023 11:31
@openshift-ci openshift-ci bot removed the lgtm label Oct 5, 2023
@pull-request-size pull-request-size bot added size/L PR that changes 100-499 lines and removed size/XL labels Oct 5, 2023
@DanielOsypenko
fix_minor
605dfc0 
Signed-off-by: Daniel Osypenko <dosypenk@redhat.com>
ocs-ci
ocs-ci reviewed Oct 5, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: dosypenk-210a
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/manage/mcg/ui/test_mcg_ui.py::TestStoreUserInterface::test_store_creation_and_deletion
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job PASSED.

@DanielOsypenko DanielOsypenko removed the Verified Mark when PR was verified and log provided label Oct 5, 2023
@openshift-ci openshift-ci bot added the lgtm label Oct 6, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 8, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DanielOsypenko, ebondare, sagihirshfeld

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DanielOsypenko DanielOsypenko added the Verified Mark when PR was verified and log provided label Oct 8, 2023
@petr-balogh petr-balogh merged commit 8a34a1d into red-hat-storage:master Oct 9, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@sagihirshfeld sagihirshfeld sagihirshfeld approved these changes

@ebondare ebondare ebondare approved these changes

@OdedViner OdedViner Awaiting requested review from OdedViner

@ebenahar ebenahar Awaiting requested review from ebenahar

@am-agrawa am-agrawa Awaiting requested review from am-agrawa

@shyRozen shyRozen Awaiting requested review from shyRozen

Assignees

@sagihirshfeld sagihirshfeld

@ebondare ebondare

@DanielOsypenko DanielOsypenko

Labels
lgtm size/L PR that changes 100-499 lines Squad/Black Covers UI specific test cases such as ODF Dashboard etc. ui_automation Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DanielOsypenko @sagihirshfeld @ebondare @ocs-ci @petr-balogh