Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend finalizer to fix teardown issue #8625

Conversation

DanielOsypenko
Copy link
Contributor

FIXES #8624

Signed-off-by: Daniel Osypenko <dosypenk@redhat.com>
@DanielOsypenko DanielOsypenko added TestCase failing Squad/Black Covers UI specific test cases such as ODF Dashboard etc. labels Oct 3, 2023
@DanielOsypenko DanielOsypenko requested a review from a team October 3, 2023 15:05
@DanielOsypenko DanielOsypenko requested a review from a team as a code owner October 3, 2023 15:05
@DanielOsypenko DanielOsypenko self-assigned this Oct 3, 2023
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines label Oct 3, 2023
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: dosypenk-310
Cluster Configuration:
PR Test Suite: tier4a
PR Test Path: tests/ui/test_odf_topology.py::TestODFTopology::test_stop_start_node_validate_topology
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job UNSTABLE (some or all tests failed).

Signed-off-by: Daniel Osypenko <dosypenk@redhat.com>
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines and removed size/S PR that changes 10-29 lines labels Oct 4, 2023
Signed-off-by: Daniel Osypenko <dosypenk@redhat.com>
@DanielOsypenko
Copy link
Contributor Author

test Pass: http://pastebin.test.redhat.com/1110196

Signed-off-by: Daniel Osypenko <dosypenk@redhat.com>
@openshift-ci openshift-ci bot added the lgtm label Oct 6, 2023
@DanielOsypenko DanielOsypenko added the Verified Mark when PR was verified and log provided label Oct 8, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 9, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DanielOsypenko, ebondare, petr-balogh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@petr-balogh petr-balogh merged commit 9468c62 into red-hat-storage:master Oct 9, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/M PR that changes 30-99 lines Squad/Black Covers UI specific test cases such as ODF Dashboard etc. TestCase failing Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_stop_start_node_validate_topology fails on teardown
4 participants