Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_pvc_bulk_creation_deletion_performance - a fix for reading pvc deletion logs in 4.14 #8674

Merged
merged 4 commits into from
Oct 19, 2023
Merged

test_pvc_bulk_creation_deletion_performance - a fix for reading pvc deletion logs in 4.14 #8674

merged 4 commits into from
Oct 19, 2023

Conversation

ypersky1980
Copy link
Contributor

This PR contains a fix to support reading deletion times from logs in 4.14.

@ypersky1980
fix for reading pvc deletion logs in 4.14
3874a6d 
Signed-off-by: Yulia Persky <ypersky@redhat.com>
@ypersky1980 ypersky1980 requested a review from a team as a code owner October 13, 2023 07:33
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines label Oct 13, 2023
@ypersky1980 ypersky1980 changed the title ypersky - test_pvc_bulk_creation_deletion_performance - a fix for reading pvc deletion logs in 4.14 test_pvc_bulk_creation_deletion_performance - a fix for reading pvc deletion logs in 4.14 Oct 13, 2023
ocs-ci
ocs-ci reviewed Oct 14, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: performance
PR Test Path: tests/e2e/performance/csi_tests/test_pvc_bulk_creation_deletion_performance.py
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job UNSTABLE (some or all tests failed).

@ypersky1980
increasing total accepted time from 60 to 80 secs
57b4866 
Signed-off-by: Yulia Persky <ypersky@redhat.com>
@ypersky1980 ypersky1980 requested a review from a team as a code owner October 14, 2023 19:50
ocs-ci
ocs-ci reviewed Oct 15, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: performance
PR Test Path: tests/e2e/performance/csi_tests/test_pvc_bulk_creation_deletion_performance.py
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job UNSTABLE (some or all tests failed).

@ypersky1980
increasing timeouts
d53afd6 
Signed-off-by: Yulia Persky <ypersky@redhat.com>
ocs-ci
ocs-ci reviewed Oct 15, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: performance
PR Test Path: tests/e2e/performance/csi_tests/test_pvc_bulk_creation_deletion_performance.py
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job UNSTABLE (some or all tests failed).

@ypersky1980
increasing default thresholds
0c0f00e 
Signed-off-by: Yulia Persky <ypersky@redhat.com>
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines and removed size/S PR that changes 10-29 lines labels Oct 15, 2023
@openshift-ci openshift-ci bot added the lgtm label Oct 16, 2023
ocs-ci
ocs-ci reviewed Oct 16, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: performance
PR Test Path: tests/e2e/performance/csi_tests/test_pvc_bulk_creation_deletion_performance.py
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job UNSTABLE (some or all tests failed).

@ypersky1980 ypersky1980 mentioned this pull request Oct 16, 2023
Closed
ocs-ci
ocs-ci reviewed Oct 18, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: performance
PR Test Path: tests/e2e/performance/csi_tests/test_pvc_bulk_creation_deletion_performance.py
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job UNSTABLE (some or all tests failed).

ocs-ci
ocs-ci reviewed Oct 18, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: performance
PR Test Path: tests/e2e/performance/csi_tests/test_pvc_bulk_creation_deletion_performance.py
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job FAILED (installation failed, tests not executed).

ocs-ci
ocs-ci reviewed Oct 18, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: performance
PR Test Path: tests/e2e/performance/csi_tests/test_pvc_bulk_creation_deletion_performance.py
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job UNSTABLE (some or all tests failed).

@ypersky1980
Copy link
Contributor Author

https://ocs4-jenkins-csb-odf-qe.apps.ocp-c1.prod.psi.redhat.com/job/qe-deploy-ocs-cluster/30655/testReport/

Please note that in the above PR validation job all the test cases PASSED.
The only test that did not pass is the Results, which is expected to fail on IBM Cloud ( no connection to Redhat Network, cannot send results to Perf Dashboard).

Therefore - this PR can be merged!

@ypersky1980 ypersky1980 added the Verified Mark when PR was verified and log provided label Oct 18, 2023
pintojoy
pintojoy approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@pintojoy pintojoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pintojoy, ramkiperiy, ypersky1980

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ramkiperiy ramkiperiy merged commit 1eb8116 into red-hat-storage:master Oct 19, 2023
5 of 7 checks passed
@ypersky1980 ypersky1980 deleted the ypersky_bulk_creation_deletion_perf_fix branch October 23, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@ramkiperiy ramkiperiy ramkiperiy approved these changes

@pintojoy pintojoy pintojoy approved these changes

Assignees

@ramkiperiy ramkiperiy

@pintojoy pintojoy

Labels
lgtm performance size/M PR that changes 30-99 lines Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ypersky1980 @ramkiperiy @ocs-ci @pintojoy