Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added deployment changes for non resilient pools. #8827

Closed
wants to merge 6 commits into from
Closed

Added deployment changes for non resilient pools. #8827

wants to merge 6 commits into from

Conversation

paraggit
Copy link
Contributor

Added deployment changes for non resilient pools.

@paraggit
Added deployment changes for non resilient pools
c925cf7 
Signed-off-by: Parag Kamble <pakamble@redhat.com>
@paraggit paraggit requested a review from a team as a code owner November 10, 2023 07:19
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Nov 10, 2023
@paraggit
Fixed KeyError exception in deployment.py
e61fd65 
Signed-off-by: Parag Kamble <pakamble@redhat.com>
@paraggit
Added DocString in the function defination
72c47e2 
Signed-off-by: Parag Kamble <pakamble@redhat.com>
@paraggit
Formatted the Deployment yaml file.
4bcae37 
Signed-off-by: Parag Kamble <pakamble@redhat.com>
@paraggit
Rearrange the conditional statement in 'verify_non_resilient_pool_dep…
d882922 
…loyment' function

Signed-off-by: Parag Kamble <pakamble@redhat.com>
@paraggit
Removed Platform Specific nonResilientPool Deployment config and move…
7ae17b6 
… it to generic location

Signed-off-by: Parag Kamble <pakamble@redhat.com>
ocs-ci
ocs-ci reviewed Nov 23, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: deployment
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master

Job FAILED (installation failed, tests not executed).

@openshift-ci openshift-ci bot added the lgtm label Jan 9, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AviadP, paraggit

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@paraggit paraggit changed the title [WIP] Added deployment changes for non resilient pools. Added deployment changes for non resilient pools. Jan 9, 2024
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AviadP
Copy link
Contributor

AviadP commented Jan 31, 2024

Hi @paraggit due to recent changes in feature description, we can close this PR in my opinion
@ebenahar

@paraggit paraggit closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@AviadP AviadP AviadP approved these changes

Assignees

@AviadP AviadP

Labels
lgtm needs-rebase size/M PR that changes 30-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paraggit @openshift-merge-robot @AviadP @ocs-ci