Adding skipif_hci_client marker with reference to skipif_ms_consumer #8895
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suchita-g
requested review from
ebenahar,
jilju,
ebondare,
DanielOsypenko and
nehaberry
Signed-off-by: suchita-g <sgatfane@redhat.com>
suchita-g
force-pushed
the
skipif_hci_client_ms
branch
from
70ba024
to
24c1a1d
Compare
ebenahar
approved these changes
Nov 20, 2023
yitzhak12
approved these changes
Nov 20, 2023
petr-balogh
approved these changes
Nov 20, 2023
petr-balogh
reviewed
Nov 20, 2023
| @@ -258,6 +259,7 @@ def test_nodereplacement_proactive_with_io_running( | |||
| @skipif_bmpsi | |||
| @skipif_external_mode | |||
| @skipif_ms_consumer | |||
| @skipif_hci_client | |||
There was a problem hiding this comment.
Maybe we can just check if it's HCI muliticluster execution, if so, to enforce switching the context of config for provider, run tests on provider clutster and return back context of config back to origin after the test will finis. But for now I am ok to disable those, but in future we can cover those cases like this I think.
petr-balogh
approved these changes
Nov 20, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amr1ta, ebenahar, petr-balogh, suchita-g, yitzhak12 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.