Add hci cluster switch check #8897
Conversation
Signed-off-by: Elena Bondarenko <ebondare@redhat.com>
Signed-off-by: Elena Bondarenko <ebondare@redhat.com>
| @@ -250,6 +250,11 @@ | |||
| reason="Test runs ONLY on OSD or ROSA cluster", | |||
| ) | |||
|
|
|||
| hci_required = pytest.mark.skipif( | |||
There was a problem hiding this comment.
Does requirement not work with hci_provider_and_client_required , do we need this explicitly.
There was a problem hiding this comment.
if no to the above comment then maybe rename it as hci_pc_platform_required or `hci_pc_cluster_required
There was a problem hiding this comment.
Yes, you're right, it would work as well.
There was a problem hiding this comment.
However, I would prefer to keep the logic of at least one hci cluster being present for the test not to be skipped, for better awareness of possible issues.
There was a problem hiding this comment.
The setup is invalid when no provider or no client is present, right? Maybe it would be better to have only one marker for hci platform to prevent redundancy.
Signed-off-by: Elena Bondarenko <ebondare@redhat.com>
ebondare
dismissed stale reviews from DanielOsypenko, fbalak, and ebenahar
via
d142bbf
Signed-off-by: Elena Bondarenko <ebondare@redhat.com>
| @@ -250,6 +250,11 @@ | |||
| reason="Test runs ONLY on OSD or ROSA cluster", | |||
| ) | |||
|
|
|||
| hci_required = pytest.mark.skipif( | |||
There was a problem hiding this comment.
if no to the above comment then maybe rename it as hci_pc_platform_required or `hci_pc_cluster_required
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ebenahar, ebondare, suchita-g The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.