Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HCI_PROVIDER_CLIENT_PLATFORMS adjustment for existing MS Conditions. #8922

Conversation

suchita-g
Copy link
Contributor

Signed-off-by: suchita-g sgatfane@redhat.com

Enable use of ceph pod from provider from pod disruptions helps

@suchita-g suchita-g added the provider-client Provider-client solution label Nov 23, 2023
@suchita-g suchita-g self-assigned this Nov 23, 2023
@suchita-g suchita-g requested a review from a team as a code owner November 23, 2023 08:33
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines label Nov 23, 2023
@suchita-g suchita-g force-pushed the addconditionHCI_PROVIDER_CLIENT_PLATFORMS branch 3 times, most recently from fc875e4 to ca582ad Compare November 23, 2023 15:27
@suchita-g suchita-g requested a review from a team as a code owner November 23, 2023 15:27
@pull-request-size pull-request-size bot added size/L PR that changes 100-499 lines and removed size/S PR that changes 10-29 lines labels Nov 23, 2023
Signed-off-by: suchita-g <sgatfane@redhat.com>

Enable use of ceph pod from provider from pod disruptions helps

Signed-off-by: suchita-g <sgatfane@redhat.com>
Signed-off-by: suchita-g <sgatfane@redhat.com>
@suchita-g suchita-g force-pushed the addconditionHCI_PROVIDER_CLIENT_PLATFORMS branch from ca582ad to 5f1441b Compare November 24, 2023 05:12
@suchita-g suchita-g requested a review from a team as a code owner November 24, 2023 05:12
Signed-off-by: suchita-g <sgatfane@redhat.com>
@suchita-g
Copy link
Contributor Author

amr1ta
amr1ta previously approved these changes Nov 24, 2023
Copy link
Contributor

@amr1ta amr1ta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@suchita-g
Copy link
Contributor Author

@suchita-g suchita-g force-pushed the addconditionHCI_PROVIDER_CLIENT_PLATFORMS branch 5 times, most recently from 3a19cbb to ecdae36 Compare November 27, 2023 10:44
amr1ta
amr1ta previously approved these changes Nov 27, 2023
@openshift-ci openshift-ci bot added the lgtm label Nov 27, 2023
@suchita-g suchita-g added the Verified Mark when PR was verified and log provided label Nov 27, 2023
jilju
jilju previously approved these changes Nov 27, 2023
Signed-off-by: suchita-g <sgatfane@redhat.com>
This resolution for some of the instances in provider-client testrun with
below error: the server doesn't have a resource type "StorageCluster"
Signed-off-by: suchita-g <sgatfane@redhat.com>
@suchita-g suchita-g dismissed stale reviews from jilju and amr1ta via 608bd89 November 27, 2023 16:26
@suchita-g suchita-g force-pushed the addconditionHCI_PROVIDER_CLIENT_PLATFORMS branch from ecdae36 to 608bd89 Compare November 27, 2023 16:26
@openshift-ci openshift-ci bot removed the lgtm label Nov 27, 2023
jilju
jilju previously approved these changes Nov 27, 2023
@openshift-ci openshift-ci bot added the lgtm label Nov 27, 2023
Signed-off-by: suchita-g <sgatfane@redhat.com>
@openshift-ci openshift-ci bot added the lgtm label Nov 27, 2023
Copy link

openshift-ci bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jilju, petr-balogh, suchita-g, vkathole

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@keesturam keesturam merged commit bf176ac into red-hat-storage:master Nov 28, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm provider-client Provider-client solution size/L PR that changes 100-499 lines Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants