add new cr and controller for peering #2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchikatw
reviewed
Jul 8, 2024
rewantsoni
force-pushed
the
scp
branch
3 times, most recently
from
1cafbac
to
9679781
Compare
nb-ohad
requested changes
Jul 23, 2024
rewantsoni
force-pushed
the
scp
branch
2 times, most recently
from
cc62c01
to
684fdef
Compare
rewantsoni
force-pushed
the
scp
branch
5 times, most recently
from
f14c83e
to
d3b82f7
Compare
nb-ohad
requested changes
Jul 23, 2024
nb-ohad
requested changes
Jul 23, 2024
ran the command: operator-sdk create api --group ocs --version v1 --kind StorageClusterPeer --resource --controller Signed-off-by: Rewant Soni <resoni@redhat.com>
Signed-off-by: Rewant Soni <resoni@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nb-ohad, rewantsoni The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
looked at the ci failures, it is because noobaa is stuck at configuring, re-testing again. |
openshift-merge-bot
bot
merged commit bb238df
into
red-hat-storage:main
11 checks passed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a new CR and controller for peering
used the command: operator-sdk create api --group ocs --version v1 --kind StorageClusterPeer --resource --controller
to create the CR and controller
Part of RHSTOR-4886