Adjust Node Label Conditions Based on Full Label Name #2841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malayparida2000
requested changes
Oct 7, 2024
OdedViner
force-pushed
the
bz-2315464
branch
3 times, most recently
from
5a4c471
to
add5a81
Compare
OdedViner
force-pushed
the
bz-2315464
branch
2 times, most recently
from
4fc1513
to
2469d23
Compare
The OCS operator searches for the topology.kubernetes.io/zone label key using a string containing logic. If the customer has a node with a label that includes the string zone. The OCS operator can read another label containing 'zone' instead of topology.kubernetes.io/zone. Signed-off-by: Oded Viner <oviner@redhat.com>
|
/lgtm /cc @iamniting |
iamniting
approved these changes
Oct 17, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, malayparida2000, OdedViner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
/test ocs-operator-bundle-e2e-aws |
openshift-merge-bot
bot
merged commit 2a2fdb2
into
red-hat-storage:main
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OCS operator searches for the
topology.kubernetes.io/zonelabel key using a string containing logic.If the customer has a node with a label that includes the string
zone.The OCS operator can read another label containing 'zone' instead of topology.kubernetes.io/zone.