Syncing latest changes from main for ocs-operator #2854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially in 4.13 when encryption in-transit was implemented we started to use msgrv2 for internal mode only. External mode & Provider mode were excluded. For external mode the concern was the availability of msgrv2 port always on the RHCS cluster. But now we have reached ceph v18 & msgrv2 is being by default on since ceph Nautilus 14.2. So we can now use mgsr2 for external mode. For provider mode the concern was availability of the required kernel versions on old client clusters. But now that concern also seems no longer valid. So we can now use msgrv2 for provider mode as well. Also as we would always use msgrv2, we can now simplify the GetCephFSKernelMountOptions function to remove the conditional checks. If encryption is enabled use "secure" otherwise "prefer-crc". Signed-off-by: Malay Kumar Parida <mparida@redhat.com>
Signed-off-by: Malay Kumar Parida <mparida@redhat.com>
Signed-off-by: Malay Kumar Parida <mparida@redhat.com>
Earlier we were adding KMS details to CephCluster, CephObjectStore Noobaa & metrics when Cluster wide encryption was enabled. But now we are adding KMS details to these places when any of the deviceSet is encrypted. Signed-off-by: Malay Kumar Parida <mparida@redhat.com>
Signed-off-by: Malay Kumar Parida <mparida@redhat.com>
Add option to enable encryption for particular deviceset & Add KMS details when any of the deviceSet is encrypted.
We are adding affinity to Noobaa if not in noobaa-standalone mode or if placement is specified. But we are not clearing the affinity if the affinity was set previously. This is breaking upgrade. Signed-off-by: Malay Kumar Parida <mparida@redhat.com>
Clear the affinity on Noobaa if it was set previously to handle upgrades
Signed-off-by: rchikatw <rchikatw@redhat.com>
change float32 to float64 in storageconsumer api
|
/retest |
include the storageCluster UID and clientID to indentify the storageConsumer from outside the cluster Signed-off-by: Rewant Soni <resoni@redhat.com>
Signed-off-by: Rewant Soni <resoni@redhat.com>
Signed-off-by: Rewant Soni <resoni@redhat.com>
|
/retest |
Signed-off-by: Oded Viner <oviner@redhat.com>
controller: update the odf-info to include client identification info
Add the verb patch to core group
|
/test ocs-operator-bundle-e2e-aws |
Use msgrv2 always for all ODF modes(internal,external,provider)
Signed-off-by: Malay Kumar Parida <mparida@redhat.com>
Add missing vendor changes
iamniting
approved these changes
Oct 18, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: df-build-team, iamniting The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from main branch