Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services: remove Getter as they generated as part of proto #2856

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rchikatw
Copy link
Contributor

  • remove Getter as they are generated as part of proto
  • not removing GetPlatformVersion() & GetOperatorVersion() as they are already used. Leela will take care of removing this.

Signed-off-by: rchikatw <rchikatw@redhat.com>
Copy link
Contributor

openshift-ci bot commented Oct 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rchikatw
Once this PR has been reviewed and has the lgtm label, please assign iamniting for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Oct 17, 2024

@rchikatw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-bundle-ocs-operator-bundle f406618 link true /test ci-bundle-ocs-operator-bundle
ci/prow/ocs-operator-bundle-e2e-aws f406618 link true /test ocs-operator-bundle-e2e-aws
ci/prow/images f406618 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant