Openshift-SDK and PF dependency version upgrade #1525
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: GowthamShanmugam The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| "@patternfly/patternfly": "5.0.4", | ||
| "@patternfly/react-charts": "7.1.1", | ||
| "@patternfly/react-core": "5.1.1", | ||
| "@patternfly/react-icons": "5.1.1", | ||
| "@patternfly/react-table": "5.1.1", | ||
| "@patternfly/react-tokens": "5.1.1", | ||
| "@patternfly/react-topology": "5.1.0", |
There was a problem hiding this comment.
we have package.json under shared as well...
There was a problem hiding this comment.
ack, will update both
|
/test odf-console-e2e-aws |
|
/retest-required |
GowthamShanmugam
force-pushed
the
update_sdk_version
branch
2 times, most recently
from
57d90f1
to
07e89fe
Compare
GowthamShanmugam
force-pushed
the
update_sdk_version
branch
from
07e89fe
to
6216060
Compare
Signed-off-by: Gowtham Shanmugasundaram <gshanmug@redhat.com>
Signed-off-by: Gowtham Shanmugasundaram <gshanmug@redhat.com>
GowthamShanmugam
force-pushed
the
update_sdk_version
branch
from
6216060
to
d7e42c6
Compare
|
@GowthamShanmugam: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
On top of: #1520
Console PR ref: openshift/console#13992
Slack Link: https://redhat-internal.slack.com/archives/C011BL0FEKZ/p1718906302730019
After the SDK version update, the stats.json file size for the bundle analysis became around 992MB, Node has a string size limit of 500MB and the current s.readFileSync(...) logic to read stats.json files fails for files >500MB. So I switched to streaming. Ref: webpack-contrib/webpack-bundle-analyzer#423