Fix bundle analyzer script #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfonsomthd
requested changes
Oct 8, 2024
GowthamShanmugam
force-pushed
the
fix_bundle_analyzer
branch
2 times, most recently
from
d136c67 to
7f08426
Compare
Signed-off-by: Gowtham Shanmugasundaram <gshanmug@redhat.com>
GowthamShanmugam
force-pushed
the
fix_bundle_analyzer
branch
from
7f08426 to
53ea858
Compare
alfonsomthd
approved these changes
Oct 9, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alfonsomthd, GowthamShanmugam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 5bdfa87
into
red-hat-storage:master
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the @aws-sdk/client-s3 version update, the stats.json file size for the bundle analysis became around 545M, Node has a string size limit of 500M and the current s.readFileSync(...) logic to read stats.json files fails for files >500MB. So I switched to streaming. Ref: webpack-contrib/webpack-bundle-analyzer#423