Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading 'react-router-dom-v5-compat' package to 6.27.0 #1654

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aruniiird
Copy link
Contributor

@aruniiird aruniiird commented Nov 4, 2024

Upgrading 'react-router-dom-v5-compat' package from '6.11.2' version to '6.27.0'
and
Removing the 'react-router-dom' package from dependencies

Task link: https://issues.redhat.com/browse/RHSTOR-6592

Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aruniiird
Once this PR has been reviewed and has the lgtm label, please assign sanjalkatiyar for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aruniiird aruniiird force-pushed the upgrade-package-react-router-dom-v5-compat branch from 54752a7 to f9a1247 Compare November 5, 2024 10:23
@aruniiird aruniiird marked this pull request as ready for review November 5, 2024 10:23
@aruniiird
Copy link
Contributor Author

@alfonsomthd , @SanjalKatiyar , please take a look...

Upgrading 'react-router-dom-v5-compat' package from '6.11.2' version to
'6.27.0'

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
@aruniiird aruniiird force-pushed the upgrade-package-react-router-dom-v5-compat branch from f9a1247 to 9c232c6 Compare November 5, 2024 10:58
Copy link
Collaborator

@alfonsomthd alfonsomthd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @SanjalKatiyar to tag it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants