Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace the setup-envtest shell script with the new binary #41

Conversation

raghavendra-talur
Copy link
Contributor

This PR replaces the setup-envtest.sh script with the go binary that controller-runtime pkg has introduced to make setting up of the test env simpler. (kubernetes-sigs/controller-runtime#1488)

Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: raghavendra-talur
To complete the pull request process, please assign agarwal-mudit after the PR has been reviewed.
You can assign the PR to them by writing /assign @agarwal-mudit in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@raghavendra-talur
Copy link
Contributor Author

This should remain in draft until the following issue is fixed:
kubernetes-sigs/controller-runtime#1571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant