Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crux_http to use form of http-types #195

Merged
merged 1 commit into from
Feb 1, 2024
Merged

crux_http to use form of http-types #195

merged 1 commit into from
Feb 1, 2024

Conversation

StuartHarris
Copy link
Member

The published http-types crate uses 128bit trace_id, which doesn't compile for wasm32-unknown-emscripten.

See http-rs/http-types#522

obmarg
obmarg reviewed Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@obmarg obmarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😔 etc (but yeah, what can we do)

@StuartHarris StuartHarris merged commit d851b47 into master Feb 1, 2024
9 checks passed
@StuartHarris StuartHarris deleted the http-types-fork branch February 1, 2024 08:27
@charypar charypar restored the http-types-fork branch February 1, 2024 10:09
@charypar charypar deleted the http-types-fork branch February 1, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obmarg obmarg obmarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StuartHarris @obmarg