Data service search #333
Merged
Data service search #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyp303
reviewed
Jun 22, 2023
ofrak_core/test_ofrak/service/data_service/data_service_interface_test.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Add method to Resource and data service to search for patterns in its data
Link to Related Issue(s)
Previously the only way to search was to request all the data then search it. This copying of data is inefficient, and searching for patterns in data is something users are likely to be interested in, so this makes sense to add to the API.
Please describe the changes in your request.
searchmethod to the data service that allows searching for either literal bytes or a regex patternsearch_datamethod to Resource which calls the DataService'ssearchmethod on itselfAnyone you think should look at this, specifically?