Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constexpr keyword to lots of small functions where possible #451

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Add constexpr keyword to lots of small functions where possible #451

merged 1 commit into from
Sep 24, 2019

Conversation

jonesmz
Copy link
Contributor

@jonesmz jonesmz commented Sep 19, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 19, 2019

Codecov Report

Merging #451 into master will decrease coverage by <.01%.
The diff coverage is 82.81%.

@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
- Coverage   84.94%   84.93%   -0.01%     
==========================================
  Files          40       40              
  Lines        6342     6341       -1     
==========================================
- Hits         5387     5386       -1     
  Misses        955      955

@jonesmz
Copy link
Contributor Author

jonesmz commented Sep 19, 2019

It's very unclear to me why the code coverage would have changed due to this PR.

@redboltz
Copy link
Owner

I re-run the bottom 4 tasks on travis-ci. They send codecov reports.
Sometimes some of them seems to fail to send report and it is NOT logged.

Perhaps codecov has time limit from the first report receiving to the last report receiving.

To be honest, I don't read much the codecov document. I just modify some example.

Here is codecov report code:
https://github.com/redboltz/mqtt_cpp/blob/master/.travis.yml#L102-L107

I guess that we can improve it.

@redboltz
Copy link
Owner

Recovered by re-run bottom four builds. - Coverage 84.94% 84.93% -0.01%

@jonesmz
Copy link
Contributor Author

jonesmz commented Sep 19, 2019

Still weird that the coverage decreased even though I removed an unused function. Oh well.

@jonesmz
Copy link
Contributor Author

jonesmz commented Sep 23, 2019

Either way, I think this code is ready to merge.

Let me know if there's anything you want me to change.

@redboltz
Copy link
Owner

Looks good to me. Thanks.

@redboltz redboltz merged commit 17fbe16 into redboltz:master Sep 24, 2019
@jonesmz jonesmz deleted the constexpr branch September 27, 2019 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants