101 requesting automatic termination of search after x time or y results #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
rc-csmith
suggested changes
Jul 10, 2023
rc-csmith
approved these changes
Jul 10, 2023
TreWilkinsRC
deleted the
101-requesting-automatic-termination-of-search-after-x-time-or-y-results
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Created one option:
--limitallows user to specify number of results returnedNote
After conducting tests with the
--limitoption, it was determined that there is no need to implement an additional timeout option after x amount of time. Setting a limit should effectively achieve the desired outcome. Open to making adjustments based on specific requirements or needs.Limits:
Cortex XDR: Default: 1000, Max: Default
Microsoft Defender for Endpoint: Default: 100000, Max: 100000
SentinelOne (PowerQuery): Default/Max: 1000
SentinelOne (Deep Visibility): Default/Max: 20000
VMware Carbon Black EDR: Default/Max: None
VMware Carbon Black Cloud Enterprise EDR: Default/Max: None
Note: Exceeding the maximum limits will automatically set the limit to its maximum value, where applicable.
closes #101