Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instrument methods #282

Merged

Conversation

patking02
Copy link
Contributor

Fixes #281

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #282 (e59af44) into master (30a1b4b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #282   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          625       652   +27     
=========================================
+ Hits           625       652   +27     
Files Coverage Δ
redcap/methods/base.py 100.00% <ø> (ø)
redcap/methods/instruments.py 100.00% <100.00%> (ø)

@pwildenhain pwildenhain linked an issue Nov 3, 2023 that may be closed by this pull request
Copy link
Collaborator

@pwildenhain pwildenhain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done again 👏🏻

See patking02#2 for a few quick fixes

Did you want me to cut another release as soon as this is merged? Or did you have more contributions you want to add in the short term?

redcap/methods/instruments.py Outdated Show resolved Hide resolved
@patking02
Copy link
Contributor Author

Nicely done again 👏🏻

See patking02#2 for a few quick fixes

Did you want me to cut another release as soon as this is merged? Or did you have more contributions you want to add in the short term?

No more contributions for the moment! Happy for you to cut another release if that is no problem!

@pwildenhain pwildenhain merged commit 1875e11 into redcap-tools:master Nov 3, 2023
11 checks passed
@patking02 patking02 deleted the 281_add_instrument_methods branch November 3, 2023 19:09
@pwildenhain
Copy link
Collaborator

Nicely done again 👏🏻
See patking02#2 for a few quick fixes
Did you want me to cut another release as soon as this is merged? Or did you have more contributions you want to add in the short term?

No more contributions for the moment! Happy for you to cut another release if that is no problem!

New release is up ❤️ https://pypi.org/project/pycap/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add instrument methods, docs, and tests Use github.triggering_actor in ci.yml
2 participants