Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Rails 6.x (was 4.2, but now we're aiming higher). #126

Open
pjsier opened this issue Dec 12, 2017 · 6 comments · Fixed by #149, #158 or #184
Open

Upgrade to Rails 6.x (was 4.2, but now we're aiming higher). #126

pjsier opened this issue Dec 12, 2017 · 6 comments · Fixed by #149, #158 or #184
Assignees
@tfe @frankduncan

Comments

@pjsier
Copy link
Contributor

pjsier commented Dec 12, 2017

We're looking at upgrading to the highest version of Rails 4.1 in #119, but when possible we should try to upgrade to Rails 4.2. This may be challenging because of the use of a deprecated form column serialization in arcdata_core that we're still looking into.
@pjsier
Copy link
Contributor Author

pjsier commented Jan 9, 2018

After reviewing this a bit more, it would definitely be a more challenging upgrade. Custom database serialization changed significantly between Rails 4.1 and 4.2, and it's relied heavily by arcdata_core, which is used throughout the application. We would need to do further research to determine more specifically how much effort this would take

@pjsier pjsier mentioned this issue Jan 9, 2018
Open
@pjsier pjsier self-assigned this Jan 26, 2018
This was referenced Feb 5, 2018
Open
Merged
@pjsier pjsier mentioned this issue Feb 21, 2018
Merged
@pjsier pjsier reopened this Jun 16, 2019
@pjsier pjsier mentioned this issue Jun 16, 2019
Merged
@jasonaowen
Copy link

Note that Rails 4.2 is no longer supported. Upgrading to Rails 4.2 may still be a useful stepping stone to upgrading to a supported version, though!

@kfogel
Copy link
Member

kfogel commented May 5, 2020

The latest stable Rails release is 6.0.2.2 (of 19 March 2020), FWIW.

@kfogel kfogel mentioned this issue May 11, 2020
Open
@kfogel kfogel assigned frankduncan and unassigned pjsier and YaxelPerez May 11, 2020
@jim-mcgowan
Copy link
Member

Upgrade Active Admin to 2.7.

@kfogel kfogel changed the title Upgrade to Rails 4.2 Upgrade to Rails 6.x (was 4.2, but now we're aiming higher). Jun 4, 2020
@frankduncan
Copy link
Contributor

This shouldn't actually have been closed because we are continuing on with rails 5 upgrade!

@frankduncan frankduncan reopened this Jun 18, 2020
@jim-mcgowan
Copy link
Member

jim-mcgowan commented Jun 18, 2020 via email

frankduncan pushed a commit that referenced this issue Jun 30, 2020
Paperclip upgrade required extra configuration
abc1b9a 
This was breaking twilio photo uploads (at least in dev).

Issue #126: Upgrade to Rails 6.x
frankduncan pushed a commit that referenced this issue Jun 30, 2020
Twilio upgrade required some small api changes
2400dab 
Issue #126: Upgrade to Rails 6.x
This was referenced Jul 4, 2020
Closed
Closed
Closed
Closed
Closed
frankduncan pushed a commit that referenced this issue Jul 12, 2020
Small updates of UI issues from #185 and #126 fixes
06ead3e 
Three issues were found:
* Shift Territory Shifts was awkward language (from County Shifts)
* A small UI update requested while in there (swapping columns in data
  scheduler)
* Bootstrap update caused some form alignment issues

Issue #185: Change entity names
frankduncan pushed a commit that referenced this issue Feb 23, 2021
Fix another hidden rails 5 upgrade issue
4379a2c 
Issue #126: Upgrade to Rails 6.x (was 4.2, but now we're aiming higher)
frankduncan pushed a commit that referenced this issue Feb 23, 2021
Fix another hidden rails 5 upgrade issue
08dc332 
Issue #126: Upgrade to Rails 6.x (was 4.2, but now we're aiming higher)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tfe tfe

@frankduncan frankduncan

Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@tfe @kfogel @jasonaowen @jim-mcgowan @frankduncan @pjsier @YaxelPerez