Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Increase chapter admin permissions #169

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 30 additions & 8 deletions app/admin/ability.rb
Original file line number Diff line number Diff line change
Expand Up @@ -49,25 +49,47 @@ def initialize(person)
is_admin = person.has_role 'chapter_admin'
if is_admin
chapter = person.chapter_id
can :read, [Roster::Person, Roster::County, Roster::Position], chapter_id: chapter
can :impersonate, Roster::Person, chapter_id: chapter
can :manage, Logistics::Vehicle, chapter_id: chapter
can :manage, HomepageLink, chapter_id: chapter

can :manage, Incidents::CallLog, chapter_id: chapter
can :manage, Incidents::Deployment, person: {chapter_id: chapter}
can :manage, Incidents::DispatchLog, chapter_id: chapter
# can :manage, Incidents::NumberSequence, chapter_id: chapter
# can :manage, Incidents::PriceListItem, chapter_id: chapter
can :new, Incidents::ReportSubscription
can :manage, Incidents::ReportSubscription, person: {chapter_id: chapter}
can [:test_report, :send_report, :new], Incidents::ReportSubscription

can :manage, Incidents::ResponderMessage, chapter_id: chapter
can :manage, Incidents::Scope, chapter_id: chapter
can :manage, Incidents::Territory, chapter_id: chapter
can :manage, Incidents::Notifications::Event, chapter_id: chapter
can :manage, Incidents::Notifications::Role, chapter_id: chapter

can [:read, :update], Scheduler::DispatchConfig, chapter_id: chapter
can :read, Incidents::DispatchLog, chapter_id: chapter
can :manage, Logistics::Vehicle, chapter_id: chapter

can :manage, Incidents::Territory, chapter_id: chapter
can :manage, Partners::Partner, chapter_id: chapter

# can :manage, Roster::CellCarrier, chapter_id: chapter
can :manage, Roster::Chapter, id: chapter
can :manage, Roster::County, chapter_id: chapter
can :manage, Roster::Person, chapter_id: chapter
can :manage, Roster::Position, chapter_id: chapter
can :manage, RegionAdminProxy do |region|
region.region_id.nil? || region.region_id == chapter
end
# can :manage, Roster::Role, chapter_id: chapter

can :manage, Scheduler::DispatchConfig, chapter_id: chapter
can :manage, Scheduler::ShiftCategory, chapter_id: chapter
can :manage, Scheduler::ShiftGroup, chapter_id: chapter
can :manage, Scheduler::Shift, county: {chapter_id: chapter}

# can :manage, DataFilter, chapter_id: chapter
can :manage, HomepageLink, chapter_id: chapter
# can :manage, Core::JobLog, chapter_id: chapter
# can :manage, Delayed::Job, chapter_id: chapter
can :manage, Lookup, chapter_id: chapter
can :manage, MOTD, chapter_id: chapter
# can :manage, NamedQuery, chapter_id: chapter
end
end

Expand Down
6 changes: 5 additions & 1 deletion app/admin/scheduler/people.rb
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,11 @@
f.actions
f.inputs do
f.has_many :position_memberships do |form|
form.input :position, collection: (f.object.chapter && f.object.chapter.positions)
if current_user.has_role 'chapter_config'
form.input :position, collection: Roster::Position.all
else
form.input :position, collection: (f.object.chapter && f.object.chapter.positions)
end
form.input :persistent
form.input :_destroy, as: :boolean, label: "Remove"
end
Expand Down