Rename tables (#185) #242
Merged
Rename tables (#185) #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 18, 2020 13:42
This is a massive change in terms of scope, but not in terms of actual changes, as rename was straightforward. It does require a few DB data updates as detailed in the included migration. Issue #185: Change entity names
This is another wide ranging change that shouldn't affect anything, as it's just a straightforward rename. Issue #185: Change entity names
Wide ranging but straightforward text change. Issue #185: Change entity names
This change is a bit more wide ranging than the other renames, because counties sometimes mean actual physical counties, and other times mean a shift territory that can be a city, zip, county, or collection of counties. For that reason, many of the times, county was changed to shift_territory, but there are many cases where a county_name became a county since there was no more confusion. Issue #185: Change entity names
This does not affect other roles such as homepage link roles, and notification roles, but only the roles attached to positions. These weren't actually roles, so the name brings them more in line with their actual purpose (capabilities), and reduces confusion. This is another wide, but not deep, change. Issue #185: Change entity names
And old database column that's no longer used on positions, used to have to do with some kind of mass notification service.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #185, changing the entity names for:
While the change is wide ranging, it is straightforward since no functionality should be changed.