Fix #148: Refactor roster query #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The query to select all the rosters included some very expensive count queries in the select portion. Because these were running for all, even before the offset/limit, they were taking too long and timing out in production. The quickest fix was to move them to their own queries after the main query was run. Issue #148: "Show Roster" hyperlink is malfunctioning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query to select all the rosters included some very expensive count
queries in the select portion. Because these were running for all, even
before the offset/limit, they were taking too long and timing out in
production. The quickest fix was to move them to their own queries
after the main query was run.
Issue #148: "Show Roster" hyperlink is malfunctioning