-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerizing #292
base: master
Are you sure you want to change the base?
Dockerizing #292
Conversation
Cannot access the server when running on docker if running on 127.0.0.1
Separate docker-compose configurations are used for running and building/dependency management to allow for live code reloading. Otherwise, this app would have to be made into a docker image and rebuilt every time a change is made.
This makefile adds the following commands: $ make setup $ make migrate $ make run $ make test $ make clean
Adds local installation instructions in INSTALL.md, and a few lines regarding testing in DEVELOPMENT.md
6e984e1
to
d448be3
Compare
This is failing to work for me. I am on debian stable, and I did
|
docker-compose.yml was running 'npm run dev', a command which no longer exists in package.json.
@frankduncan It should work now. I think |
@YaxelPerez Now I'm getting
I have update the config.json on my machine to have smoke/smoke as username and password for the DB. Is that what's breaking it? |
@YaxelPerez I also tried changing the username/pw in the docker-compose.yml. |
@frankduncan Managed to get the same error. username and password needs to be the same in I looked into having the makefile read credentials from |
@YaxelPerez We should create template files and .gitignores so that people don't accidentally check in their development passwords into source control. After that, have documentation about the move. Also, now that I've done that, I am running into
when running the admin access script so I can log in. The docker db is running via |
This PR adds a docker-compose configuration and makefile to make it easier to run this project for development.