This repository is currently being migrated. It's locked while the migration is in progress.
Add secrets fetcher tests where none existed before #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanBalfanz
force-pushed
the
secrets-fetcher-tests
branch
from
038cc68 to
39b1142
Compare
RyanBalfanz
changed the title
mathyourlife-reddit
approved these changes
Nov 6, 2024
chriskuehl
reviewed
Nov 6, 2024
Co-authored-by: Chris Kuehl <ckuehl@ckuehl.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
💸 TL;DR
Add tests to secrets fetcher sidecar, none existed before. These tests help to capture existing behavior so that changes can be made to secrets fetching with confidence.
I started looking at the atomicity of secrets fetching (i.e. the temporary file), in particular a common failure mode using
json.dumpcausing partial writes and malformed JSON files, but want to add some tests before making any changes to the implementation.📜 Details
Design Doc
Jira
🧪 Testing Steps / Validation
✅ Checks