-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump waitress from 2.1.1 to 2.1.2 #678
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering there are no security patches or needed bugfixes in this version,a 94% compatibility rating seems like a little more risk than I would like. Thoughts @nsheaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KTAtkinson I don't think the change is that drastic considering the actual code changes, but I'm not clear on how to ensure that this works properly for all of our use cases other than merging and having people try it out (beyond the tests that currently exist). We could upgrade some of the services we own and test it out there but based on our past upgrade experiences I don't think that's sufficient unfortunately.
Bumps [waitress](https://github.com/Pylons/waitress) from 2.1.1 to 2.1.2. - [Release notes](https://github.com/Pylons/waitress/releases) - [Changelog](https://github.com/Pylons/waitress/blob/v2.1.2/CHANGES.txt) - [Commits](Pylons/waitress@v2.1.1...v2.1.2) --- updated-dependencies: - dependency-name: waitress dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
df2632c
to
0cc7bd5
Compare
Our testing methodology has improved to the point where we should be able to validate this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should go out with next release.
Thanks Katie! 🏃 |
Bumps waitress from 2.1.1 to 2.1.2.
Changelog
Sourced from waitress's changelog.
Commits
0aa4879
Remove change of default for clear_untrusted_proxy_headers2784628
Revert "Merge pull request #370 from Yourun-proger/del_warnings"479df63
Prep 2.1.24f6789b
Merge pull request #377 from Pylons/bugfix/select-closed-socket-race1952050
Merge pull request #379 from Pylons/enhancement/pyupgrade-3.78f5b473
pyupgrade 3.7c7a3d7e
Only close socket in the main thread7c3739b
Merge pull request #376 from Pylons/bugfix/header-calculation3066fdd
Merge pull request #378 from Pylons/bugfix/expose_tracebacks-encode-error4467d76
Fix tests to assume body is bytesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.