Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(file_watcher): Atomic writes to watched files #755

Merged
merged 1 commit into from
Nov 18, 2022
Merged

docs(file_watcher): Atomic writes to watched files #755

merged 1 commit into from
Nov 18, 2022

Conversation

KTAtkinson
Copy link
Contributor

Add documentation pointing out that if writes to watched files aren't atomic, file contents observed by clients may be corrupted.

Closes #

💸 TL;DR

📜 Details

Design Doc

Jira

🧪 Testing Steps / Validation

✅ Checks

  • CI tests (if present) are passing
  • Adheres to code style for repo
  • Contributor License Agreement (CLA) completed if not a Reddit employee

@KTAtkinson
docs(file_watcher): Atomic writes to watched files
9cf71fc 
Add documentation pointing out that if writes to watched files aren't
atomic, file contents observed by clients may be currupted,
w
@KTAtkinson KTAtkinson marked this pull request as ready for review October 20, 2022 00:33
@KTAtkinson KTAtkinson requested a review from a team as a code owner October 20, 2022 00:33
@KTAtkinson KTAtkinson merged commit bc2d21f into develop Nov 18, 2022
@KTAtkinson KTAtkinson deleted the katie-atkinson-document-filewatcher branch November 18, 2022 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghirsch-reddit ghirsch-reddit ghirsch-reddit approved these changes

@maeivysea maeivysea maeivysea approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KTAtkinson @maeivysea @ghirsch-reddit