Populate Cassandra cluster name from cluster metadata #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cluster name label allows us to map the client queries back to the cluster they are being executed on. It can be used to determine client query error rates and latencies broken down by cluster and map these back to specific queries similar to how `cassandra_client_name` is used. If the metadata field is not populated, this returns an empty string. The metadata field is populated on connect and refreshed at a regular interval, however, the cluster name will not change.
kylelemons
requested changes
Nov 10, 2022
|
This is the one that "asks" the cluster for its own name. In this case, the python cassandra driver already queries the cluster for a bunch of metadata on connection, including the cluster name, so we just use that queried cluster name - its the same as the cluster name returned by DESCRIBE CLUSTER. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cluster name label allows us to map the client queries back to the cluster they are being executed on. It can be used to determine client query error rates and latencies broken down by cluster and map these back to specific queries similar to how
cassandra_client_nameis used.If the metadata field is not populated, this returns an empty string. The metadata field is populated on connect and refreshed at a regular interval, however, the cluster name will not change.
Closes #
💸 TL;DR
Introduces
cassandra_cluster_nameprometheus label for Cassandra client request metrics.It can be used to determine client query error rates and latencies broken down by cluster and map these back to specific queries similar to how
cassandra_client_nameis used.If the cluster does not return the cluster name metadata field, this returns an empty string. However,
the cluster name is populated as part of the Cassandra driver's
connectcall.📜 Details
Baseplate.spec PR
Jira
🧪 Testing Steps / Validation
Unit test and integration test introduced.
✅ Checks