Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert sidecar changes to expose Prometheus metrics #762

Merged
merged 2 commits into from
Dec 5, 2022
Merged

revert sidecar changes to expose Prometheus metrics #762

merged 2 commits into from
Dec 5, 2022

Conversation

ghirsch-reddit
Copy link
Contributor

@ghirsch-reddit ghirsch-reddit commented Dec 5, 2022 •
edited
Loading

💸 TL;DR

This causes problems when deployed with graphql. Reverting while we investigate.

📜 Details

Jira

✅ Checks

  • CI tests (if present) are passing
  • Adheres to code style for repo

@ghirsch-reddit ghirsch-reddit requested a review from a team as a code owner December 5, 2022 18:03
davinci26
davinci26 approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@davinci26 davinci26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty for the revert! cc @SuperQ

@SuperQ
Copy link
Contributor

SuperQ commented Dec 5, 2022

LGTM

@ghirsch-reddit ghirsch-reddit merged commit d31fc3c into develop Dec 5, 2022
@ghirsch-reddit ghirsch-reddit deleted the DEVX-976 branch December 5, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davinci26 davinci26 davinci26 approved these changes

@KTAtkinson KTAtkinson KTAtkinson approved these changes

@nsheaps nsheaps Awaiting requested review from nsheaps nsheaps is a code owner automatically assigned from reddit/baseplate-py

@aba-ca-xi aba-ca-xi Awaiting requested review from aba-ca-xi aba-ca-xi is a code owner automatically assigned from reddit/baseplate-py

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ghirsch-reddit @SuperQ @KTAtkinson @davinci26