Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove thirft-unofficial reference #781

Merged
merged 2 commits into from
Apr 6, 2023
Merged

Remove thirft-unofficial reference #781

merged 2 commits into from
Apr 6, 2023

Conversation

pnovotnak
Copy link
Contributor

@pnovotnak pnovotnak commented Apr 4, 2023 •
edited
Loading

💸 TL;DR

In #778 we changed the thrift-unofficial reference in the requirements file, but not in setup.py.

📜 Details

(N/A)

🧪 Testing Steps / Validation

✅ Checks

  • CI tests (if present) are passing
  • Adheres to code style for repo
  • Contributor License Agreement (CLA) completed if not a Reddit employee

@pnovotnak pnovotnak marked this pull request as ready for review April 4, 2023 18:11
@pnovotnak pnovotnak requested a review from a team as a code owner April 4, 2023 18:11
@KTAtkinson KTAtkinson added v2.6 Pull requests to be included in v2.6 dependencies Pull requests that update a dependency file labels Apr 4, 2023
@KTAtkinson KTAtkinson merged commit c4eb840 into reddit:develop Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maeivysea maeivysea maeivysea approved these changes

@KTAtkinson KTAtkinson KTAtkinson approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file v2.6 Pull requests to be included in v2.6
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pnovotnak @KTAtkinson @maeivysea