Add psycopg2 extra, patch psycogreen in entry points. #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salomon-smekecohen
force-pushed
the
issue-62
branch
from
d1ae05d
to
ac7c646
Compare
chriskuehl
approved these changes
May 20, 2024
Comment on lines
+42
to
+43
| psycopg2 = "^2.0.0" | ||
| psycogreen = "^1.0.0" |
There was a problem hiding this comment.
Hmm, I'm surprised this doesn't need to be marked with optional = true like the other extra dependencies, but I checked and the built wheel seems to correctly mark it as only needed with the extra:
Requires-Dist: psycogreen (>=1.0.0,<2.0.0) ; extra == "psycopg2"
Requires-Dist: psycopg2 (>=2.0.0,<3.0.0) ; extra == "psycopg2"
There was a problem hiding this comment.
Thanks Chris! Yeah maybe I messed this up, I have never added an extra using poetry before. If you have a docs link to how you did it ill give it a read to try and track down differences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #62
💸 TL;DR
If you want to use psycopg2, baseplate should automatically patch it for gevent. You can use sqlalchemy with a variety of postgres packages, not just psycopg2. So make the dependencies an extra instead of attaching to sqlalchemy or a "sqlalchemy-postgres" extra.
🧪 Testing Steps / Validation
Pointed my Baseplate.py project to this hash, no issues. Patch works as expected.
✅ Checks