Adds the watermark component #6
Conversation
| @@ -0,0 +1,135 @@ | |||
| import { Devvit } from "@devvit/public-api"; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
suggest moving the prop docs to separate JSDocs colocated with the props. when we document them in a big block like this, the IDE can't parse it and readability everywhere outside this site is much lower. you might be able to use @prop syntax but I discourage it since it's so much more verbose and you have to keep the name in the docs aligned to the name in the code.
|
|
||
| /** | ||
| * A component that appends the watermark to the container it is wrapped around | ||
| * @param appName - the app name that is specified in devvit.yaml |
There was a problem hiding this comment.
I think these docs need to be on WatermarkProps.
| props, | ||
| context, | ||
| ) => { | ||
| const is1stPartyApp = props.developer === "Reddit"; |
There was a problem hiding this comment.
🔕 I don't know if this varies across languages. I guess we're pretty single lingual right now regardless.
There was a problem hiding this comment.
This watermark is a temporary solution and will be deprecated before translation is an issue
Copyedit.
Copyedit.
Description:
Adds a simple watermark component
🧪 Testing Steps / Validation
Tested in Play
✅ Checks