Switches to using User Data Directory to store credentials instead of homedir #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… homedir - Switches to using User Data Directory to store credentials instead of homedir. - if User Data Directory is not applicable for an OS then it falls back on using the homedir to save credentials.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
📜 Details
The goal of this PR is to make devvit conform to each operating system's user data directory guidelines for storing app data instead of creating directory in home directory. This is where the devvit directory will be depending on the OS.
C:\\Users\\<user>\\AppData\\Local\\devvit/Users/<user>/Library/Application Support/devvit/home/<user>/.local/share/devvitIf none of the OS in the list above matches then it defaults to using homedir for storing credentials.
🧪 Testing Steps / Validation
This PR hasn't been tested yet because I couldn't build locally on my machine :/
✅ Checks