Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node v18 -> v22 #29

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Node v18 -> v22 #29

merged 2 commits into from
Jul 25, 2024

Conversation

ben-harris-5
Copy link
Contributor

@ben-harris-5 ben-harris-5 commented Jul 25, 2024 •
edited
Loading

💸 TL;DR

We're trying to get all of the dev platform up to supporting Node v22, and that includes Play!

📜 Details

  • Set the node engine to be v22 or greater.
  • Change how JSON imports are worded.

🧪 Testing Steps / Validation

No functional changes.

✅ Checks

  • CI tests (if present) are passing
  • Adheres to code style for repo
  • Contributor License Agreement (CLA) completed if not a Reddit employee

@ben-harris-5 ben-harris-5 requested a review from niedzielski July 25, 2024 22:12
niedzielski
niedzielski approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@niedzielski niedzielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bless

@ben-harris-5 ben-harris-5 merged commit baa9c0d into main Jul 25, 2024
1 check passed
@ben-harris-5 ben-harris-5 deleted the node-v22 branch July 25, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niedzielski niedzielski niedzielski approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ben-harris-5 @niedzielski @colacadstink