Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request: Startup log prints current NODE_ENV #103

Closed
kcjonson opened this issue Apr 19, 2016 · 1 comment
Closed

Request: Startup log prints current NODE_ENV #103

kcjonson opened this issue Apr 19, 2016 · 1 comment
Labels
enhancement New functionality.

Comments

@kcjonson
Copy link

When starting the server (particularly for the first time) We're not really explicit as to what NODE_ENV was found. We mention in the docs that it defaults to staging but we don't actually log out something along the lines of NODE_ENV defaulting to 'staging'

Just a little friendlier than 2016-04-19T22:00:45.054Z - warning: [react-server-cli.src.index] -- NODE_ENV is not set to "production".
@gigabo gigabo added the enhancement New functionality. label Apr 29, 2016
@gigabo gigabo changed the title Request: Startup log prints current NODE_INV Request: Startup log prints current NODE_ENV Apr 29, 2016
@gigabo gigabo added this to the v0.3.0 milestone Apr 29, 2016
@gigabo gigabo removed this from the v0.3.0 milestone May 19, 2016
doug-wade added a commit to doug-wade/react-server that referenced this issue May 25, 2016
@doug-wade
Fix redfin#103: log NODE_ENV on startup
4842e51
@doug-wade doug-wade mentioned this issue May 25, 2016
Merged
doug-wade added a commit to doug-wade/react-server that referenced this issue May 25, 2016
@doug-wade
Fix redfin#103: log NODE_ENV on startup
92cfb20
doug-wade added a commit to doug-wade/react-server that referenced this issue May 25, 2016
@doug-wade
Fix redfin#103: log NODE_ENV on startup
1ef9296
doug-wade added a commit to doug-wade/react-server that referenced this issue May 25, 2016
@doug-wade
Fix redfin#103: log NODE_ENV on startup
b6b02bf
doug-wade added a commit to doug-wade/react-server that referenced this issue May 25, 2016
@doug-wade
Fix redfin#103: log NODE_ENV on startup
0acf2e9
doug-wade added a commit that referenced this issue May 25, 2016
@doug-wade
Fix #103: log NODE_ENV on startup (#211)
0db4444
@kcjonson
Copy link
Author

Thanks Doug!

davidalber pushed a commit to davidalber/react-server that referenced this issue Jul 24, 2016
@doug-wade @davidalber
Fix redfin#103: log NODE_ENV on startup (redfin#211)
825f97c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gigabo @kcjonson