Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass in the token to be replaced in the module tagger #12

Closed
gigabo opened this issue Feb 12, 2016 · 2 comments
Closed

Pass in the token to be replaced in the module tagger #12

gigabo opened this issue Feb 12, 2016 · 2 comments
Labels
enhancement New functionality.

Comments

@gigabo
Copy link
Contributor

gigabo commented Feb 12, 2016

Something like:

var tagger = require("react-server-gulp-module-tagger");
...
gulp.src(...).pipe(tagger("__LOGGER__"));
@doug-wade
Copy link
Collaborator

To allow using different tokens in client code, rather than LOGGER? And we should def keep the current values as defaults so that you can still .pipe(tagger())

gigabo added a commit to gigabo/react-server that referenced this issue Mar 5, 2016
Just 'cause, you know... it might be useful.

Wouldn't be necessary if redfin#12 were done, but this is way faster.
@gigabo gigabo added enhancement New functionality. help wanted labels Apr 29, 2016
@doug-wade
Copy link
Collaborator

This is now possible with the babel plugin, but I think we should leave the issue until we support it in the gulp plugin as well.

doug-wade added a commit that referenced this issue Aug 17, 2016
doug-wade added a commit that referenced this issue Aug 17, 2016
Fix #12 Support configurable tokens for the gulp module tagger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New functionality.
Projects
None yet
Development

No branches or pull requests

2 participants