Use babel preset in cli #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is blocking on 0.4.0 to publish |
|
@doug-wade - Blocking on 0.4.0 of what? |
|
@gigabo React Server! |
|
It requires breaking changes? |
|
Whichever version we publish next. Semver versions before 0 are kinda squishy -- adding two new packages to the ecosystem seemed like it might merit more than patch version change. |
doug-wade
force-pushed
the
use-babel-preset-in-cli
branch
2 times, most recently
from
15b8bc7 to
454f32f
Compare
| @@ -38,7 +38,7 @@ | |||
| "jasmine": "2.3.1", | |||
| "jsdom": "5.6.1", | |||
| "jsx-loader": "0.12.2", | |||
| "lerna": "2.0.0-beta.23", | |||
| "lerna": "git://github.com/lerna/lerna.git#master", | |||
There was a problem hiding this comment.
build is passing locally with my lerna built off master (which runs prepublish as part of bootstrap), but not on ci so I tried pulling from master. However, lerna's master branch isn't a functioning node module, so this isn't working either. Next, I'll try a lerna run prepublish on ci, but if that doesn't work, we may just need to wait for lerna-2.0.0-beta.24
doug-wade
force-pushed
the
use-babel-preset-in-cli
branch
from
454f32f to
bc8ee85
Compare
doug-wade
force-pushed
the
use-babel-preset-in-cli
branch
from
bc8ee85 to
efbc7a3
Compare
doug-wade
force-pushed
the
use-babel-preset-in-cli
branch
from
efbc7a3 to
12133f1
Compare
davidalber
pushed a commit
to davidalber/react-server
that referenced
this pull request
Jul 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transpile the cli (but not its clients) with babel-preset-react-server