Cli commands #490
Cli commands #490
Conversation
- start - compile - init (not yet implemented)
A little optimistic. Some commands not yet implemented. :p
| @@ -4,7 +4,7 @@ simultaneously, so port conflicts will fail the tests. Make sure | |||
| to update this manifest when adding a test that starts a server. | |||
|
|
|||
| ## generator-react-server | |||
| 3010, 3011 | |||
| 3000, 3001 | |||
There was a problem hiding this comment.
doesn't 3001 conflict with react-server-integration-test?
There was a problem hiding this comment.
I don't think so. I think react-server-integration-test uses a dummy static asset server.
There was a problem hiding this comment.
Nope, you're right. 😞
| // | ||
| // Gotta do this the old-fashioned way. :p | ||
| // | ||
| export default function ConfigurationError(message) { |
There was a problem hiding this comment.
We might want to consider using VError for our custom error classes
| import setupLogging from "../setupLogging"; | ||
| import logProductionWarnings from "../logProductionWarnings"; | ||
|
|
||
| const logger = require("react-server").logging.getLogger(__LOGGER__); |
There was a problem hiding this comment.
I thought we were trying to set the pattern of import {logging} from 'react-server'; const logger = loggin.getLogger(__LOGGER__);? Or is that a non-goal?
| @@ -0,0 +1,10 @@ | |||
| import fs from "fs"; | |||
|
|
|||
| export default function fileExists(fn) { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
^ That still throws. This is just a helper that returns boolean.
| @@ -119,6 +136,14 @@ const sslize = argv => { | |||
| } | |||
| } | |||
|
|
|||
| if (argv.https && (argv.httpsKey || argv.httpsCert || argv.httpsCa || argv.httpsPfx || argv.httpsPassphrase)) { | |||
| throw new Error("If you set https to true, you must not set https-key, https-cert, https-ca, https-pfx, or https-passphrase."); | |||
There was a problem hiding this comment.
If we decide to go all-in with good error handling (probably out-of-scope), maybe a ParseError?
There was a problem hiding this comment.
For ordinary errors where stack trace is actually desirable I don't see any need to subclass.
applies here too
|
I had a lot to say about this pr, but its super awesome and I like the new interface way better and I whole-heartedly endorse this plan. Thanks for pulling this together @gigabo |
|
Gonna merge this because I want to build on it. @aickin - If you get a chance please take a look! |
Now that the CLI can be installed globally it can be used to bootstrap a React Server site.
This is totally new functionality that's only tangentially related to the previous "start server" behavior. So... I've added "commands".
The new quick start in the CLI doc looks like:
$ npm install -g react-server-cli $ react-server init $ react-server add-page '/' Homepage $ react-server startThis is a pretty big change to the interface of
react-server-cli.@aickin - How does this look to you?