Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require node 6 to run react-server-cli #528

Merged
merged 1 commit into from
Aug 11, 2016

Conversation

lidawang
Copy link
Contributor

cc @gigabo

@gigabo
Copy link
Contributor

gigabo commented Aug 11, 2016

Thanks @lidawang! Will be nice to pick up lerna/lerna#192 when it lands so we can drop the extra two copies of cli.js here. 😛

@doug-wade
Copy link
Collaborator

This seems like its going backwards to me. Node 4 supports destructuring, but its behind a flag; can you try adding the --harmony_destructuring flag to https://github.com/redfin/react-server/blob/master/packages/react-server-cli/bin/react-server-cli#L1, rather than removing the destructuring? I don't think we want to try to support node < 4.

@gigabo
Copy link
Contributor

gigabo commented Aug 11, 2016

@doug-wade - This is actually just the top-most entry point for react-server-cli. We have a couple of extra copies laying around until the next version of Lerna lands, but after that it will just be this one tiny file that needs this treatment. :)

(Note the require("babel-core/register"); at the top)

@doug-wade
Copy link
Collaborator

@gigabo oh, I see. sorry @lidawang, lgtm 👍

@gigabo gigabo merged commit 2e00c79 into redfin:master Aug 11, 2016
@gigabo gigabo added the bug An issue with the system label Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with the system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants