-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
another command to use ffip-diff-*
#78
Comments
On a closely related topic, I've been having trouble getting ffip-ffip-show-diff to pass on Debian's Continuous Integration infrastructure. Self-tests pass fine on the buildd infrastructure after a1ec308, but CI seems to be even more strict, and more limited, so I put in the time to try to run them without test.sh. So far I've failed. I think the problem is ido-completing-read sets default-directory back to ./ (eg: find-file-in-project). The strange thing is set default-directory didn't work with dh_elpa's ert testing, but (cd "tests") did. I uploaded this branch here: BUILD-LOG-BACKTRACE has the backtrace. I wonder if this (#78) issue will also run into trouble with default-directory (whether on your end, or on Continous Integration). At any any rate, I hope my experiment failed in a way that's useful ;-) |
It's fine to use |
When reading through the commit history I found 8eedc93, and after reading that I realised why the CI tests were failing, and also that a1ec308 is no longer necessary. Find-file-in-project now has continuous integration testing :-) Here's the link for current status and logs: In conclusion, there seems to be something in Debian CI that prevents setting default-directory or ffip-project-root, but methods that depend on I believe my modifications to how tests are run are almost certainly Debian-specific, but here is the source for our package: |
Good to know. Thanks. |
You're welcome. P.S. Re: abo-abo ivy code, Ivy/swiper tests run 100% fine out of the box, with no special configuration, so I'm guessing they're a good model :-) |
create a buffer containing diff content, set default-directory (check abo-abo ivy code),
enable
ffip-diff-mode
The text was updated successfully, but these errors were encountered: