Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

another command to use ffip-diff-* #78

Open
redguardtoo opened this issue Aug 21, 2017 · 5 comments
Open

another command to use ffip-diff-* #78

redguardtoo opened this issue Aug 21, 2017 · 5 comments

Comments

@redguardtoo
Copy link
Owner

create a buffer containing diff content, set default-directory (check abo-abo ivy code),
enable ffip-diff-mode

@sten0
Copy link
Contributor

sten0 commented Nov 30, 2017

On a closely related topic, I've been having trouble getting ffip-ffip-show-diff to pass on Debian's Continuous Integration infrastructure. Self-tests pass fine on the buildd infrastructure after a1ec308, but CI seems to be even more strict, and more limited, so I put in the time to try to run them without test.sh.

So far I've failed. I think the problem is ido-completing-read sets default-directory back to ./ (eg: find-file-in-project). The strange thing is set default-directory didn't work with dh_elpa's ert testing, but (cd "tests") did. I uploaded this branch here:
https://github.com/sten0/find-file-in-project/tree/experiment

BUILD-LOG-BACKTRACE has the backtrace. I wonder if this (#78) issue will also run into trouble with default-directory (whether on your end, or on Continous Integration). At any any rate, I hope my experiment failed in a way that's useful ;-)

@redguardtoo
Copy link
Owner Author

It's fine to use cd instead of setup default-directory in test cases. If you only change test cases, I'm OK to review and accept your pull request asap.

@sten0
Copy link
Contributor

sten0 commented Nov 30, 2017

When reading through the commit history I found 8eedc93, and after reading that I realised why the CI tests were failing, and also that a1ec308 is no longer necessary.

Find-file-in-project now has continuous integration testing :-) Here's the link for current status and logs:
https://ci.debian.net/packages/f/find-file-in-project/

In conclusion, there seems to be something in Debian CI that prevents setting default-directory or ffip-project-root, but methods that depend on cd are ok, and getting default-directory works.

I believe my modifications to how tests are run are almost certainly Debian-specific, but here is the source for our package:
https://anonscm.debian.org/git/pkg-emacsen/pkg/find-file-in-project.git

@redguardtoo
Copy link
Owner Author

Good to know. Thanks.

@sten0
Copy link
Contributor

sten0 commented Dec 1, 2017

You're welcome.

P.S. Re: abo-abo ivy code, Ivy/swiper tests run 100% fine out of the box, with no special configuration, so I'm guessing they're a good model :-)
https://ci.debian.net/packages/e/emacs-ivy/
https://buildd.debian.org/status/package.php?p=emacs-ivy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants