-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Action to Node 16 and handle set-output deprecation #109
Update Action to Node 16 and handle set-output deprecation #109
Conversation
sorry for not opening an issue before opening this, if it is necessary I can create one after the fact and I won't have any hard feelings if you choose to close this due to it being a requirement. Regardless, if this is acceptable and you are interested in receiving similar PRs in the other Action repos I would be more than happy to help out.
|
Regarding the ESLint, I can fix them, yet I opted to change as little code as possible within this PR as its scope was solely bumping the dependencies up to recent versions. |
@divyansh42, @jduimovich, @tetchel sorry for the ping on this, but any chance of getting feedback? Thank you for your work on all of these actions! |
c82ec77
to
8ce6dd7
Compare
re-based on the current master and bumped the devDependencies to their current versions * I shall fix the ESLint errors once this is deemed acceptable as a PR |
Unfortunately it seems this project is kind of dead, but since there was a commit 2 weeks ago there is still some hope. Thanks for the work! |
it would be very unfortunate if this action would wind up dead as I see |
We see that as well, that's why we forked the repo to get some important changes in. We don't really plan to maintain this though, so it would be nice if this here would become more active. Quite embarrassing for an organization like RedHat if you ask me. |
okay, I tried to fix all the eslint errors (after the eslint updates), however, I have no idea how this ever worked or how it was intended to work: Lines 125 to 131 in 4b8d367
The rest was mostly parameter arrangement "problems" (was not sure on the code style target of the project so adhered to eslint's interpretation) |
well, fixed it as well as the logic 😅 |
3fc8832
to
cabe407
Compare
cabe407
to
b6d3d05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @k3rnelpan1c-dev for the detailed PR and accept my apologies for delay in the review.
Due to some other priorities, we took too much time to respond.
I have provided a minor review, please take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @jduimovich
We have created the release for the same. |
Nice! Thank you for the heads up (Renovate already started notifying me of the new version on some of my repos 🚀) |
Description
This PR aims to update this GitHub Action to a recent state.
Its initial aim is to use the "new" Node16 Action runtime as the currently used Node12 runtime is phased out relatively soon (alternative to #107).
It also pins and updates the dependencies used within the Action to their latest versions (ideally this should be handled by something such as Renovate-Bot or Dependabot).
In turn this PR updates to the latest
@actions/core
, which in turn fixes the deprecation of theset-output
command.Finally, this PR updates all Actions used within the workflows of this repositoy and adds an
.editorconfig
file to help new contributors.Related Issue(s)
Checklist
Changes made
node12
tonode16
@actions/core
from^1.9.1
to1.10.0
(addresses theset-output
deprecation)@actions/exec
from^1.0.4
to1.1.1
@actions/io
from^1.0.2
to1.1.2
ini
from^2.0.0
to3.0.1
@redhat-actions/action-io-generator
from^1.5.0
to1.5.0
@redhat-actions/eslint-config
from^1.3.2
to1.3.2
@redhat-actions/tsconfig
from^1.1.1
to1.2.0
@types/ini
from^1.3.30
to1.3.31
@types/node
from^12
to16.18.7
@typescript-eslint/eslint-plugin
from^4.28.2
to5.46.0
@typescript-eslint/parser
from^4.28.2
to5.46.0
@vercel/ncc
from^0.25.1
to0.34.0
eslint
from^7.30.0
to8.29.0
typescript
from^4.3.5
to4.9.4
.editorconfig
(based on format present in repo)