-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor inputs to support docker/metadata-action #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution 👍
I think this PR is very accurate and perfect as per implementation.
The only thing that needs to be done is to update the input description (as we have changed those) in action.yml
and in README
.
Do you want to update/improve the documentation to clearly explain the changes? (In the same way, suggested at redhat-actions/push-to-registry#50 (comment)) |
@tetchel Done with refactoring and added documentation. PTAL. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Output image
will be empty when using FQIN, can we add a note about this in the README output section?
Also, it will be great if we can add another example for FQIN in output tags
and image-with-tag
in README output section.
lgtm, i'm going to hold this until the PTR one is approved too and then we can merge both and make sure they make sense together. |
This PR adds support for docker/metadata-action@v2. See #74.
Description
Support
tags
input in full image name form. When full image name form is used, inputimage
would be optional.Related Issue(s)
Closes #74
Checklist
Changes made
image
is now declared asrequired: false
, and checked during runtime.tags
input are split by/\s+/
instead of" "
because docker/metadata-action's output is newline separated.